Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nargo): add test for reading/writing inputs to fs #996

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

#995

Description

Summary of changes

This PR adds a quick test that if we write an input map and return value to a file then we will recover the same values when we read from that file again.

As we're now testing equality outside of noirc_abi we need to always derive PartialEq.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench changed the title chore: add test for reading/writing inputs to fs chore(nargo): add test for reading/writing inputs to fs Mar 16, 2023
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like tests 🎉

@TomAFrench TomAFrench enabled auto-merge March 16, 2023 20:03
@TomAFrench TomAFrench added this pull request to the merge queue Mar 16, 2023
Merged via the queue into master with commit 284c5e9 Mar 16, 2023
@TomAFrench TomAFrench deleted the test-writing-inputs-to-file branch March 16, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants